-
Notifications
You must be signed in to change notification settings - Fork 4.1k
THRIFT-5855: Add netstd fuzzers #3203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jens-G
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the new source files lack the ASF header.
b0e7a8b to
4f11cea
Compare
|
I checked twice that I installed sharpfuzz according to the docs but I always get I used the docker jammy build environment, if that is relevant. |
|
Ping? |
|
see also #3235 |
|
ah, sorry for the delay here, life got in the way - I'll make a pass this weekend |
|
it looks like after the move to .net 10, this may not be possible, as sharpfuzz doesn't seem to support it. I'll have to do some more research (I'm not a .NET expert unfortunately) |
|
Well, net10 was released only few weeks ago. They might need some time. Since it is the current LTS I would expect it will be supported soon. |
Experimental RFC for netstd fuzzers. Requesting review for this one as I'm not sure if this is idiomatic C#, or how to build these projects.
I'm worried about bitrot here. Makefile inclusion will hopefully ensure these build in CI and we don't bitrot the build, but if no one's running these fuzzers regularly (due to lack of oss-fuzz support) I'm not sure how impactful these will be.
[skip ci]anywhere in the commit message to free up build resources.