Skip to content

UUID Cross test debugging and observations #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CJCombrink wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

UUID Cross test debugging and observations #3144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b85508
Disable a few options
CJCombrink May 20, 2025
06bc244
Print the UUID that Go sends
CJCombrink May 20, 2025
2e5a705
Force swift to print known UUID
CJCombrink May 21, 2025
7e5e16e
Add the test pattern to the C++ side
CJCombrink May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/docker/scripts/cross-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
set -ev

./bootstrap.sh
./configure --enable-tutorial=no
./configure --enable-tutorial=no --with-cl=no --with-d=no --with-dart=no
make -j3 precross

set +e
make cross$1

RET=$?
if [ $RET -ne 0 ]; then
if [ -f "test/features/log/unexpected_failures.log" ]; then
if [ -f "test/features/log/unexpected_failures.log" ]; then
cat "test/features/log/unexpected_failures.log"
fi
if [ -f "test/log/unexpected_failures.log" ]; then
Expand Down
1 change: 1 addition & 0 deletions test/cpp/src/TestClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ int main(int argc, char** argv) {
UUID_TEST(testUuid, TUuid{"5e2ab18817264e75a04f1ed9a6a89c4c"}, expected_uuid);
UUID_TEST(testUuid, TUuid{"{5e2ab18817264e75a04f1ed9a6a89c4c}"}, expected_uuid);
UUID_TEST(testUuid, TUuid{}, TUuid{"00000000-0000-0000-0000-000000000000"});
UUID_TEST(testUuid, TUuid{"00112233-4455-6677-8899-aabbccddeeff"}, TUuid{"00112233-4455-6677-8899-aabbccddeeff"});

/**
* STRUCT TEST
Expand Down
1 change: 1 addition & 0 deletions test/go/src/bin/testclient/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ func callEverything(client *thrifttest.ThriftTestClient) {
0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff,
}
u, err := client.TestUuid(defaultCtx, uout)
t.Printf("TestUuid(%v)", uout)
if err != nil {
t.Fatalf("TestUuid failed with %v", err)
}
Expand Down
3 changes: 2 additions & 1 deletion test/swift/CrossTests/Sources/TestClient/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,8 @@ Bân-lâm-gú, 粵語
}*/

func testUuid() throws {
let uuid = UUID()
let uuid = UUID(uuidString: "00112233-4455-6677-8899-aabbccddeeff")!
print("testUuid(\(uuid))")
guard try client.testUuid(thing: uuid) == uuid else {
resultCode |= Error.baseTypes.rawValue
return
Expand Down
Loading