Skip to content

feat(ag-grid): Server Side Filtering for Column Level Filters #35683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat(ag-grid): Server Side Filtering for Column Level Filters #35683

wants to merge 6 commits into from
+1,817 −11

Conversation

amaannawab923
Copy link
Contributor

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@amaannawab923
initial : server side filters implementation
daa3f36
@amaannawab923
update: filters ux improvement
49eca8e
@amaannawab923
refactor(ag-grid): improve filter converter type safety and error han…
ce8eb54 
…dling

- Replace all `any` types with `FilterValue` type union for strict type safety
- Add comprehensive input validation for column names, filter values, and operators
- Implement graceful error handling with console.error/warn instead of throwing
- Add FILTER_OPERATORS and SQL_OPERATORS constants to replace string literals
- Remove unnecessary console.log statements and logFilterConversion method
- Clean up verbose JSDoc comments while preserving essential documentation
- Ensure invalid filters are logged and skipped without blocking UX
@korbit-ai Korbit AI
Copy link

korbit-ai bot commented Oct 16, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@bito-code-review Bito Code Review
Copy link
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugins review:draft size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amaannawab923 @sadpandajoe