Skip to content

Conversation

rebenitez1802
Copy link
Contributor

SUMMARY

Fixes the "Automatically sync columns" checkbox being unresponsive when editing virtual datasets. The checkbox appears to be stuck and doesn't toggle state when clicked.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Navigate to a virtual dataset (one with SQL query)
  2. Click "Edit Dataset"
  3. Modify the SQL query (change the query text)
  4. Click "Save" button
  5. Confirmation modal appears with "Automatically sync columns" checkbox (checked by default)
  6. Click the checkbox - it should uncheck
  7. Click it again - it should check
  8. Verify the checkbox responds to each click and toggles state correctly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Oct 14, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

Copy link
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@rebenitez1802 rebenitez1802 marked this pull request as ready for review October 14, 2025 23:34
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/components/Datasource/DatasourceModal/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@dosubot dosubot bot added change:frontend Requires changing the frontend data:dataset Related to dataset configurations labels Oct 15, 2025
@sadpandajoe
Copy link
Member

Can we add two tests to test the fix?

  1. Test to sync and validate the PUT request fires for the sync
  2. Test to uncheck the checkbox to make sure it is unchecked and then submit and validate that the PUT request fires and should not be syncing

… override_columns=true and not sync columns when checkbox is unchecked and submits with override_columns=false
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend data:dataset Related to dataset configurations size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants