WW-5525 Prevent NPE when using new in OGNL #1200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eters target and member #WW-5525
|
Failing tests about the issue pass after the fix. It only stays DynAttribsTest which does not pass ( |
FBibonne
commented
Feb 1, 2025
| @@ -141,6 +141,10 @@ public void restore(Map context, Object target, Member member, String propertyNa | |||
| public boolean isAccessible(Map context, Object target, Member member, String propertyName) { | |||
| LOG.debug("Checking access for [target: {}, member: {}, property: {}]", target, member, propertyName); | |||
|
|
|||
| if (member == null){ | |||
There was a problem hiding this comment.
If member is null, it can cause others NPE (for example at line 151) and according the contract of the method a null member is a non sense
|
Thank you @kusalk for fixing this NPE Your PR 1214 looks very fine to my point of view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.