[SDP] [SPARK-52576] Drop/recreate on full refresh and MV update #51280
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sryza
changed the title
szehon-ho
approved these changes
Jun 25, 2025
| val dropTable = (isFullRefresh || !table.isStreamingTableOpt.get) && existingTableOpt.isDefined | ||
| if (dropTable) { | ||
| catalog.dropTable(identifier) | ||
| // context.spark.sql(s"DROP TABLE ${table.identifier.quotedString}") |
There was a problem hiding this comment.
nit: remove? Optionally add comment about why not truncate/alter?
| val dropTable = (isFullRefresh || !table.isStreamingTableOpt.get) && existingTableOpt.isDefined | ||
| if (dropTable) { | ||
| catalog.dropTable(identifier) | ||
| // context.spark.sql(s"DROP TABLE ${table.identifier.quotedString}") |
There was a problem hiding this comment.
shall we remove this line?
| @@ -446,8 +446,9 @@ class MaterializeTablesSuite extends BaseCoreExecutionTest { | |||
|
|
|||
| val table2 = catalog.loadTable(identifier) | |||
| assert( | |||
| table2.columns() sameElements CatalogV2Util | |||
| .structTypeToV2Columns(new StructType().add("y", IntegerType).add("x", BooleanType)) | |||
| table2.columns().toSet == CatalogV2Util | |||
There was a problem hiding this comment.
why do we need this change?
There was a problem hiding this comment.
The ordering of columns does not appear to be deterministic (at least across different catalog implementations). Is that unexpected?
There was a problem hiding this comment.
for a table, the column order matters. I think we should keep the test as it is and fix the issues we found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some pipeline runs result in wiping out and replacing all the data for a table:
In the current implementation, this "wipe out and replace" is implemented by:
The reason that we want originally wanted to truncate + alter instead of drop / recreate is that dropping has some undesirable effects. E.g. it interrupts readers of the table and wipes away things like ACLs.
However, we discovered that not all catalogs support dropping columns (e.g. Hive does not), and there’s no way to tell whether a catalog supports dropping columns or not. So this PR changes the implementation to drop/recreate the table instead of truncate/alter.
Why are the changes needed?
See section above.
Does this PR introduce any user-facing change?
Yes, see section above. No releases contained the old behavior.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No