[SPARK-52572][PS] Avoid CAST_INVALID_INPUT of DataFrame.isin in ANSI mode #51276
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ueshin may I get a review please? |
ueshin
approved these changes
Jun 25, 2025
python/pyspark/pandas/frame.py
Outdated
| if is_ansi_mode_enabled(self._internal.spark_frame.sparkSession): | ||
| col_type = self._internal.spark_type_for(label) | ||
| scol = self._internal.spark_column_for(label).isin( | ||
| [F.lit(v).try_cast(col_type.simpleString()) for v in values] |
There was a problem hiding this comment.
Make sense! Adjusted.
|
Merged to master thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid CAST_INVALID_INPUT of DataFrame.isin in ANSI mode
Why are the changes needed?
Ensure pandas on Spark works well with ANSI mode on.
Part of https://issues.apache.org/jira/browse/SPARK-52556.
Does this PR introduce any user-facing change?
Yes.
isinworks without CAST_INVALID_INPUT.How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.