[SPARK-52569][SQL] Fix the class cast exception in SecondsOfTimeWithFraction
#51270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
SecondsOfTimeWithFractionSecondsOfTimeWithFraction
MaxGekk
changed the title
SecondsOfTimeWithFractionSecondsOfTimeWithFraction
MaxGekk
commented
Jun 24, 2025
| StaticInvoke( | ||
| classOf[DateTimeUtils.type], | ||
| DecimalType(8, 6), | ||
| "getSecondsOfTimeWithFraction", | ||
| Seq(child, Literal(precision)), | ||
| Seq(child.dataType, IntegerType)) | ||
| } | ||
| private val precision: Int = child.dataType.asInstanceOf[TimeType].precision |
There was a problem hiding this comment.
This val is initialized before the invoke of inputTypes(), so, asInstanceOf[TimeType] can fail on other types.
|
@LuciferYang @HyukjinKwon Could you review this PR, please. |
LuciferYang
approved these changes
Jun 25, 2025
|
Merging to master. Thank you, @LuciferYang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to avoid an assumption in the
SecondsOfTimeWithFractionexpression: the default constructor is called only onTimeTypeofchild. The constructor can be called before theinputTypesmethod, and we cannot guarantee that input types areTimeType(n)only. Thechildexpression can beNullType, for instance.Why are the changes needed?
To avoid the following exception while calling expression's methods:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running new check:
Was this patch authored or co-authored using generative AI tooling?
No.