-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-52503][SQL][CONNECT] Fix drop
when the input column is not existent
#51196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
drop
when the input column is not existentdrop
when the input column is not existent
9a20490
to
b44c7b3
Compare
5870637
to
9e00a12
Compare
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala
Outdated
Show resolved
Hide resolved
...lyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDataFrameDropColumns.scala
Show resolved
Hide resolved
...lyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDataFrameDropColumns.scala
Show resolved
Hide resolved
9e00a12
to
ef9af3d
Compare
@@ -509,6 +509,27 @@ trait ColumnResolutionHelper extends Logging with DataTypeErrorsBase { | |||
includeLastResort = includeLastResort) | |||
} | |||
|
|||
// Try to resolve `UnresolvedAttribute` by the children with Plan Ids. | |||
// Returns `None` if fail to resolve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this implemented? I see we pass throws = true
when calling resolveExpression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it cannot find the plan id in the plan, then it fails;
if the plan id is found, but cannot resolve it, then return None
What changes were proposed in this pull request?
Fix
drop
when the input column is not existentWhy are the changes needed?
bugfix
df3
doesn't containsdf1["colB"]
, so no columns should be dropped.Does this PR introduce any user-facing change?
yes, bug fix
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no