[Breaking Change] Remove H2 as storage option permanently. #12909
Conversation
|
Many H2 relative e2e will fail. Wait for fixing. |
|
Unless we totally remove all supports for SQL databases, it doesn't seem to reduce that much maintenance work by only removing H2, but I see it increases development workload, now you have to start a database first. |
As I am answering most of the community questions, and k8s is the most popular deployment platform, I am suffering that payload by H2 can't work in k8s and new users don't predict for that. By |
|
mysql and pg are being considered, I actually want to do that after some discussions. |
| @@ -284,7 +284,7 @@ public static Span buildSpanFromRecord(ZipkinSpanRecord record) { | |||
| //Build remoteEndpoint | |||
| Endpoint.Builder remoteEndpoint = Endpoint.newBuilder(); | |||
| remoteEndpoint.serviceName(record.getRemoteEndpointServiceName()); | |||
| if (!StringUtil.isEmpty(record.getLocalEndpointIPV4())) { | |||
| if (!StringUtil.isEmpty(record.getRemoteEndpointIPV4())) { | |||
There was a problem hiding this comment.
fyi @wankai123 This seems to be an existing bug.
| @@ -37,7 +37,7 @@ cases: | |||
| expected: expected/func-OP.yml | |||
|
|
|||
| # topN-OP-service Global | |||
| - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics exec --expression="top_n(service_sla,3,des)/100" | |||
| - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics exec --expression="top_n(service_resp_time,3,des)" | |||
There was a problem hiding this comment.
@wankai123 sla e2e sorting is not predictable, so, we changed to another metric.
CHANGESlog.production-ready. Don't need H2 as default storage anymore.
FYI @apache/skywalking-committers I keep deceasing the extra maintenance payload of us. BanyanDB, elasticsearch/opensearch and mysql/postgresql are our main support now.