-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Add GraalVM Reachability Metadata and corresponding nativeTest for Presto Memory Connector #34429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65e7283 to
f2053c4
Compare
7 tasks
d1b882f to
1440b65
Compare
1440b65 to
04e9c2a
Compare
linghengqian
commented
Jan 24, 2025
Member
Author
linghengqian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Presto Server's healthcheck started to behave strangely. After executing SQL statements such as
CREATE SCHEMA memory.demo_ds_0, the return value of/v1/info/stateon the 8080 port of Presto Server would switch from"ACTIVE"to other values within an unknown period of time. This ultimately results in the error logNo nodes available to run querybeing displayed.
0e96ab5 to
727cdd7
Compare
727cdd7 to
15670dd
Compare
15670dd to
fafe958
Compare
linghengqian
commented
Feb 7, 2025
Member
Author
linghengqian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Bypassing prestodb/presto#23226 is not a good thing. This introduces unstable CI.
linghengqian
commented
May 24, 2025
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- An interesting turn of events occurred in presto 0.292 compared to presto 0.290. See #35504 .
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
org.graalvm.buildtools.maven.MetadataCopyMojohas Typo graalvm/native-build-tools#689Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.