Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(operator): refactor network chaos in Chaos reconciliation #404

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Jun 8, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@mlycore mlycore added this to the 0.3.0 milestone Jun 8, 2023
@github-actions github-actions bot added the operator solutions of operator label Jun 8, 2023
@mlycore mlycore added type: refactor in: chaos modules of shardingsphere chaos and removed operator solutions of operator labels Jun 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #404 (2b4e77e) into main (3604a24) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   39.71%   39.73%   +0.01%     
==========================================
  Files          51       51              
  Lines        6083     6080       -3     
==========================================
  Hits         2416     2416              
+ Misses       3448     3445       -3     
  Partials      219      219              
Impacted Files Coverage Δ
...ator/cmd/shardingsphere-operator/manager/option.go 49.53% <0.00%> (ø)
...phere-operator/pkg/controllers/chaos_controller.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mlycore mlycore added the operator solutions of operator label Jun 8, 2023
@tristaZero tristaZero merged commit 6bd6444 into apache:main Jun 8, 2023
@mlycore mlycore deleted the netchaos branch June 8, 2023 06:06
@mlycore
Copy link
Contributor Author

mlycore commented Jul 11, 2023

ref #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: chaos modules of shardingsphere chaos operator solutions of operator type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants