[Feature][Connector-V2] Kafka Source support to read TIMESTAMP_TZ #9984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hohosznta , |
|
Let's merge the latest changes and try again. |
|
@dybyte thanks, I'll try again. |
|
@dybyte Hi, all CI/CD checks have passed. I’d really appreciate it if you could take a look at my PR. |
dybyte
reviewed
Nov 3, 2025
Comment on lines
+339
to
+362
| case TIMESTAMP_TZ: | ||
| DateTimeFormatter dateTimeTzFormatter = fieldFormatterMap.get(fieldName); | ||
| if (dateTimeTzFormatter == null) { | ||
| dateTimeTzFormatter = DateTimeUtils.matchDateTimeFormatter(field); | ||
| fieldFormatterMap.put(fieldName, dateTimeTzFormatter); | ||
| } | ||
| if (dateTimeTzFormatter == null) { | ||
| throw CommonError.formatDateTimeError(field, fieldName); | ||
| } | ||
|
|
||
| TemporalAccessor parsedTimestampTz = dateTimeTzFormatter.parse(field); | ||
| LocalTime localTimeTz = parsedTimestampTz.query(TemporalQueries.localTime()); | ||
| LocalDate localDateTz = parsedTimestampTz.query(TemporalQueries.localDate()); | ||
| ZoneOffset offset = parsedTimestampTz.query(TemporalQueries.offset()); | ||
|
|
||
| if (offset == null) { | ||
| offset = ZoneId.systemDefault().getRules().getOffset(Instant.now()); | ||
| } | ||
|
|
||
| if (localDateTz == null || localTimeTz == null) { | ||
| throw CommonError.formatDateTimeError(field, fieldName); | ||
| } | ||
|
|
||
| return OffsetDateTime.of(localDateTz, localTimeTz, offset); |
There was a problem hiding this comment.
Please add a test case for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Add support for TIMESTAMP_TZ on kafka source. Issue #9785
Does this PR introduce any user-facing change?
Yes. The Kafka source connector now supports TIMESTAMP_TZ (timestamp with timezone) data type.
Users can now consume Kafka messages containing timestamp with timezone information (e.g., "2024-01-15T10:30:45Z",
"2024-01-15T10:30:45+09:00") and SeaTunnel will correctly parse them as OffsetDateTime.
How was this patch tested?
Added unit test case in json parsing timestamp_tz in JsonRowDataSerDeSchemaTest.java. (testDeserializationWithTimestampTz)
Check list
New License Guide