Skip to content

Conversation

@zhangshenghang
Copy link
Member

@zhangshenghang zhangshenghang commented Oct 22, 2025

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

- Implemented hashModForField to generate CRC32-based modulo expressions
- Added ABS function to ensure non-negative results
- Used quoteIdentifier to properly escape field names
davidzollo
davidzollo previously approved these changes Oct 26, 2025
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo changed the title [Imporve][Connector-v2][MySQL] Optimize shard calculation strategy [Improve][Connector-v2][MySQL] Optimize shard calculation strategy Oct 26, 2025
@Hisoka-X
Copy link
Member

Let's add a unit test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants