[ISSUE #9147] Remove unused code #9148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9148 +/- ##
=============================================
+ Coverage 47.99% 48.03% +0.04%
- Complexity 12061 12063 +2
=============================================
Files 1321 1321
Lines 93024 93018 -6
Branches 11926 11924 -2
=============================================
+ Hits 44643 44683 +40
+ Misses 42842 42805 -37
+ Partials 5539 5530 -9 ☔ View full report in Codecov by Sentry. |
yx9o
approved these changes
Jan 20, 2025
caigy
requested changes
Jan 21, 2025
Comment on lines
-778
to
-781
| throw new MQClientException( | ||
| "consumerGroup is null" | ||
| + FAQUrl.suggestTodo(FAQUrl.CLIENT_PARAMETER_CHECK_URL), | ||
| null); |
There was a problem hiding this comment.
IMO exception thrown in Validators.checkGroup should keep this more detailed error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9147
Brief Description
producer group don't need repeat check.
How Did You Test This Change?
Delete the code and run maven test, then no error happend.