[ISSUE #9112] Speedup revive scan in Pop Consumption and support server side reset offset #9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t server side reset offset
|
@redlsz Please help review this pr |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9113 +/- ##
=============================================
+ Coverage 47.94% 47.96% +0.01%
- Complexity 12037 12042 +5
=============================================
Files 1320 1320
Lines 92827 92840 +13
Branches 11897 11898 +1
=============================================
+ Hits 44507 44528 +21
+ Misses 42809 42805 -4
+ Partials 5511 5507 -4 ☔ View full report in Codecov by Sentry. |
lollipopjin
reviewed
Jan 8, 2025
broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerKVStore.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er side reset offset
Which Issue(s) This PR Fixes
Fixes #9112
Brief Description
How Did You Test This Change?