Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Continue Pulsar CI build even when Trivy scanner fails #23397

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 4, 2024

Motivation

Error message in https://github.com/apache/pulsar/actions/runs/11179184671/job/31078661681#step:13:42 was:

2024-10-04T12:05:48Z	FATAL	Fatal error	image scan error: scan error: scan failed: failed analysis: analyze error: pipeline error: failed to analyze layer (sha256:e2f493e066e35423c1459a42bb7c97d05f71f262edd92fbb61e45afd5c1c1ae0): post analysis error: post analysis error: Unable to initialize the Java DB: Java DB update failed: DB download error: OCI repository error: 1 error occurred:
	* GET https://ghcr.io/v2/aquasecurity/trivy-java-db/manifests/1: TOOMANYREQUESTS: retry-after: 297.486µs, allowed: 44000/minute

Modifications

Add continue-on-error: true to Trivy steps in Pulsar CI.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Error message was:
2024-10-04T12:05:48Z	FATAL	Fatal error	image scan error: scan error: scan failed: failed analysis: analyze error: pipeline error: failed to analyze layer (sha256:e2f493e066e35423c1459a42bb7c97d05f71f262edd92fbb61e45afd5c1c1ae0): post analysis error: post analysis error: Unable to initialize the Java DB: Java DB update failed: DB download error: OCI repository error: 1 error occurred:
	* GET https://ghcr.io/v2/aquasecurity/trivy-java-db/manifests/1: TOOMANYREQUESTS: retry-after: 297.486µs, allowed: 44000/minute
@lhotari lhotari requested a review from merlimat October 4, 2024 13:15
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 4, 2024
@lhotari lhotari requested a review from onobc October 4, 2024 13:16
@lhotari lhotari added this to the 4.0.0 milestone Oct 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (bbc6224) to head (359cba5).
Report is 631 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23397      +/-   ##
============================================
+ Coverage     73.57%   74.50%   +0.93%     
- Complexity    32624    34547    +1923     
============================================
  Files          1877     1937      +60     
  Lines        139502   145430    +5928     
  Branches      15299    15895     +596     
============================================
+ Hits         102638   108359    +5721     
+ Misses        28908    28758     -150     
- Partials       7956     8313     +357     
Flag Coverage Δ
inttests 27.41% <ø> (+2.83%) ⬆️
systests 24.50% <ø> (+0.18%) ⬆️
unittests 73.87% <ø> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 614 files with indirect coverage changes

@merlimat merlimat merged commit 56200aa into apache:master Oct 4, 2024
55 of 56 checks passed
lhotari added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants