-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ci] Upgrade/Downgrade test #22988
Conversation
@lhotari ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dlg99, this is very useful. I have provided review feedback to make this more generic and usable in maintenance branches.
...on/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarUpgradeDowngradeTest.java
Outdated
Show resolved
Hide resolved
...on/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarUpgradeDowngradeTest.java
Outdated
Show resolved
Hide resolved
...on/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarUpgradeDowngradeTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @dlg99
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22988 +/- ##
============================================
+ Coverage 73.57% 74.54% +0.97%
- Complexity 32624 33934 +1310
============================================
Files 1877 1937 +60
Lines 139502 145433 +5931
Branches 15299 15897 +598
============================================
+ Hits 102638 108414 +5776
+ Misses 28908 28688 -220
- Partials 7956 8331 +375
Flags with carried forward coverage won't be shown. Click here to find out more. |
+ "chmod -R ug+rwx /pulsar/data && " | ||
+ "chown -R 10000:0 /pulsar/data && " | ||
+ "rm -rf /pulsar/data/* && " | ||
+ "while true; do echo \"$MAGIC_NUMBER\" | nc -l -p 80; done"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this command?
Motivation
catch issues like #22051
Modifications
Added a test for upgrade/downgrade
Verifying this change
This change adds tests.
Does this pull request potentially affect one of the following parts:
NO
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dlg99#18