-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix][sec] Update dependencies to use snakeyaml 2.0 against 3.0 #20223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-3.0
Are you sure you want to change the base?
[fix][sec] Update dependencies to use snakeyaml 2.0 against 3.0 #20223
Conversation
ac42864
to
6719ec5
Compare
6719ec5
to
82ebabd
Compare
82ebabd
to
1d6036a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a corner regression by Jackson 2.15. It will affect our json schema. We will need to talk about it this in the dev mail list.
FasterXML/jackson-databind#3874
@codelipenghui @Technoboy- @lhotari @michaeljmarshall @tisonkun would you mind taking a look? |
251b089
to
3fde2e3
Compare
3fde2e3
to
271228d
Compare
I don't know if we would have the same concern in Pulsar, but jclouds attempted this upgrade and had to revert it. |
Hi @dave2wave In my PR on master eugene-cheverda#1 I had successful runs of CI with this change, also the discussion on update to jackson 2.15.0 is held here. |
The pr had no activity for 30 days, mark with Stale label. |
Covered by #20085. |
No. They are different issue. |
The pr had no activity for 30 days, mark with Stale label. |
@eugene-cheverda does this PR still apply? |
Fixes #20224
Motivation
Fixes https://avd.aquasec.com/nvd/cve-2022-1471 caused by snakeyaml by updating all dependencies bringing it into the project
Modifications
Updated jackson, snakeyaml and prometheus dependencies, updated code to use non-deprecated EnumResolver functions
Verifying this change
This change is already covered by existing tests, such as FieldParserTest.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: eugene-cheverda#2