Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] test with scala 3.6.2 #1722

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pjfanning
Copy link
Contributor

No description provided.

@pjfanning pjfanning marked this pull request as draft January 16, 2025 14:15
@He-Pin
Copy link
Member

He-Pin commented Jan 16, 2025

IIRC, we need to use ? instead of [_] in type parameter

@He-Pin
Copy link
Member

He-Pin commented Jan 17, 2025

@xuwei-k Do you have some drop-in rules to support this, thanks.

@pjfanning
Copy link
Contributor Author

pjfanning commented Jan 17, 2025

IIRC, we need to use ? instead of [_] in type parameter

So far, this is not causing us an issue. The builds for this PR do not show this as an issue. We still support Scala 2.12 builds, so we can't make massive code changes. We can make some small changes if they help us getter closer to Scala 3.6 support.

If it comes to making large PRs, then I think we need to abandon this until we start Pekko 2.0.0 work.

@xuwei-k
Copy link
Contributor

xuwei-k commented Jan 17, 2025

scalafmt support rewrite [_] to [?].

latest Scala 2.12.x and 2.13.x support new wildcard syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants