chore: enable test.multi-node test during pr and nightly build. - #1592
chore: enable test.multi-node test during pr and nightly build.#1592He-Pin wants to merge 1 commit into
Conversation
He-Pin
left a comment
There was a problem hiding this comment.
Enabling MultiJvm/test in PR and nightly builds is important for catching cluster-related regressions early.
-
CI impact: Multi-node tests are expensive and slow. Are there concerns about CI duration? The change appears minimal (just toggling flags in workflow files).
-
Flakiness risk: Multi-node tests can be flaky, especially in CI environments. Has the author verified these tests pass reliably on CI?
-
Staleness: Open since December 2024 with no reviews. @He-Pin mentioned running MultiJvm tests locally. It would be good to see CI results before merging. If the tests are stable, this is a straightforward and valuable improvement.
|
Closing due to staleness and merge conflicts. Enabling multi-node tests in PR/nightly builds is a significant CI decision that needs team discussion around test duration and flakiness tradeoffs. If there is consensus to proceed, a fresh PR with that discussion can be opened. |
Motivation:
refs: #1591
Need to make sure
MultiJvm/testpass.I was running
MultiJvm/testcode locally.