Skip to content

chore: enable test.multi-node test during pr and nightly build. - #1592

Closed
He-Pin wants to merge 1 commit into
apache:mainfrom
He-Pin:clusterTest
Closed

chore: enable test.multi-node test during pr and nightly build.#1592
He-Pin wants to merge 1 commit into
apache:mainfrom
He-Pin:clusterTest

Conversation

@He-Pin

@He-Pin He-Pin commented Dec 16, 2024

Copy link
Copy Markdown
Member

Motivation:
refs: #1591

Need to make sure MultiJvm/test pass.

I was running MultiJvm/test code locally.

@He-Pin He-Pin left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling MultiJvm/test in PR and nightly builds is important for catching cluster-related regressions early.

  1. CI impact: Multi-node tests are expensive and slow. Are there concerns about CI duration? The change appears minimal (just toggling flags in workflow files).

  2. Flakiness risk: Multi-node tests can be flaky, especially in CI environments. Has the author verified these tests pass reliably on CI?

  3. Staleness: Open since December 2024 with no reviews. @He-Pin mentioned running MultiJvm tests locally. It would be good to see CI results before merging. If the tests are stable, this is a straightforward and valuable improvement.

@He-Pin

He-Pin commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Closing due to staleness and merge conflicts. Enabling multi-node tests in PR/nightly builds is a significant CI decision that needs team discussion around test duration and flakiness tradeoffs. If there is consensus to proceed, a fresh PR with that discussion can be opened.

@He-Pin He-Pin closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant