[parquet] add vector support for parquet#8282
Open
steFaiz wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for adding Parquet vector support. One correctness concern: VectorType is fixed-size, but this implementation encodes it as a Parquet LIST and currently accepts whatever list length is present. On the write path, ParquetRowDataWriter writes row.getVector(...).size() without checking it against VectorType.getLength(); on the read path, CastedVectorColumnVector returns a ColumnarVec using the Parquet list length, not the declared vector length. That can let malformed vectors be written/read and then fail later in Spark/DataConverter or vector indexing with less context. Could we validate the vector length at the Parquet boundary, and ideally add a test for mismatched length? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently parquet format do not recognize vector type. This will cause
UnsupportedOperationExceptionif users' do not store vectors in separated format. e.g. Lance, VortexTests
UnitTests