[Core][Bug] Fix bug when read changelog's IndexManifest. #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
force-pushed
the
fix_bug_when_read_changelog_0211
branch
from
95b25cb to
8920493
Compare
|
Can you add a test case? |
wwj6591812
changed the title
wwj6591812
force-pushed
the
fix_bug_when_read_changelog_0211
branch
from
8920493 to
1b25558
Compare
wwj6591812
changed the title
Done，Please CC, Thx. |
JackeyLee007
pushed a commit
to JackeyLee007/paimon
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We encountered an exception in our production job.
After investigate this issue, the reason of this exception is :
We open
Changelogdecouple, theChangeloghas records theindexManifest. But theSnapshotof theChangeloghas been expired. So when read thisChangelogwill read the non-existedindexManifest.We have think two functions to solve this problem.
1、 Don't read the
indexManifestwhen streaming read theChangelog.2、Override the
indexManifestmethod inChangelog, which return null forever.Due to the design of
ChangelogandTagis extendsSnapshot, they should not modify the field ofSnapshot. So after discuss we choose the function 1.Linked issue: close #xxx
Tests
API and Format
Documentation