-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix missing kotlin and okio dependencies when using okhttp3. #5044
[core] Fix missing kotlin and okio dependencies when using okhttp3. #5044
Conversation
@@ -284,13 +298,23 @@ under the License. | |||
<artifactSet> | |||
<includes combine.children="append"> | |||
<include>com.squareup.okhttp3:okhttp</include> | |||
<include>com.squareup.okio:okio-jvm</include> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify NOTICE file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find the NOTICE file in okio-jvm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will modify it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need add content in /paimon/paimon-core/src/main/resources/META-INF/NOTICE
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.squareup.okio:okio:3.6.0
licence from: https://mvnrepository.com/artifact/com.squareup.okio/okio/3.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
The reason is okio‘s version so just add okio is ok. |
paimon-core/pom.xml
Outdated
<artifactId>okio-jvm</artifactId> | ||
<version>${okio.version}</version> | ||
</dependency> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<dependency>
<groupId>com.squareup.okio</groupId>
<artifactId>okio</artifactId>
<version>${okio.version}</version>
</dependency>
just add this is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll try it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still : java.lang.ClassNotFoundException: kotlin.jvm.internal.Intrinsics
Now. I'll try shade okio.
<dependency> <groupId>com.squareup.okio</groupId> <artifactId>okio</artifactId> <version>${okio.version}</version> </dependency>
just add this is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean add okio, but still need to shade it. Because there is other version okio.
I have tried, both |
Can you write how to trigger this problem? |
I used the partition mark done action of |
try this change |
Still : ClassNotFoundException: kotlin.jvm.internal.Intrinsics. After testing, |
fe419a1
to
bf7a8f5
Compare
bf7a8f5
to
b635741
Compare
I use the change when package it into the development environment. It works well. |
If you find |
https://github.com/apache/paimon/actions/runs/13236825342/job/36943312581 I get |
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation