[flink] Infer parallelism only in situation of parallelism is not set. #4975
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,8 @@ void testInferScanParallelism() throws Exception { | |||
| null); | |||
| PaimonDataStreamScanProvider runtimeProvider = runtimeProvider(tableSource); | |||
| StreamExecutionEnvironment sEnv1 = StreamExecutionEnvironment.createLocalEnvironment(); | |||
| sEnv1.setParallelism(-1); | |||
| System.out.println(sEnv1.getParallelism()); | |||
There was a problem hiding this comment.
This print seems unnecessary.
| @@ -149,9 +149,18 @@ protected Integer inferSourceParallelism(StreamExecutionEnvironment env) { | |||
| Boolean.parseBoolean(envConfig.toMap().get(FLINK_INFER_SCAN_PARALLELISM))); | |||
| } | |||
| Integer parallelism = options.get(FlinkConnectorOptions.SCAN_PARALLELISM); | |||
| if (parallelism == null && options.get(FlinkConnectorOptions.INFER_SCAN_PARALLELISM)) { | |||
| if (parallelism == null | |||
There was a problem hiding this comment.
I'm trying to understand the parallelism inferring logic this PR wants to achieve, please see if this is correct.
- If Paimon option SCAN_PARALLELISM is configured, then use this value.
- Else if Flink configuration
parallelism.defaultis configured, then use this value. - Else if Paimon option INFER_SCAN_PARALLELISM is set to true, and the parallelism of source can be inferred by Paimon (like when fixed bucket + unbounded stream), then Paimon would provide an inference result.
- Else Paimon would not set the parallelism of the source operator, instead it would be Flink infra that decide the parallelism of this operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
default.parallelism is not working because scan.infer-parallelism is default true
Tests
API and Format
Documentation