feat(file_index): add file index format read and write #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devillove084
force-pushed
the
feat/impl_file_index_format
branch
from
980dd62 to
96cdef9
Compare
|
This update involves the reconstruction of FileIndexFormat's reading and writing functionalities based on the new FileIO. To keep the changes manageable, I’ve split the PR into smaller parts. If you have a moment, I would greatly appreciate reviews. @Xuanwo @SteNicholas |
Xuanwo
reviewed
Aug 24, 2024
This was referenced Aug 24, 2024
devillove084
force-pushed
the
feat/impl_file_index_format
branch
2 times, most recently
from
82f47ea to
5f4f2f8
Compare
|
Sorry for being late again. I have corrected all your comments. Please review them when you have time to see if there are any problems. Thank you very much. @Xuanwo |
devillove084
force-pushed
the
feat/impl_file_index_format
branch
from
5f4f2f8 to
c761c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part #34