Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableRead supports reading multiple splits parallely #11

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Sep 4, 2024

Purpose

TableRead#create_reader read splits parallely by default. If user hasn't set thread number, then it fallback to sequentially read.

Tests

API and Format

Documentation

@yuzelin yuzelin force-pushed the parallel-read-splits branch 2 times, most recently from f186f88 to 44d4985 Compare September 4, 2024 09:11
batch_iterator = self._batch_generator()
return RecordBatchReader.from_batches(self._arrow_schema, batch_iterator)

def create_reader_from_split(self, split: Split):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this method

def create_reader_from_split(self, split: Split) -> RecordBatchReader:
"""Reader that only read one split."""

def create_reader_from_plan(self, plan: Plan) -> RecordBatchReader:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this method

@yuzelin yuzelin changed the title Add TableRead#create_parallel_reader for reading multiple splits parallely TableRead supports reading multiple splits parallely Sep 5, 2024
@yuzelin yuzelin force-pushed the parallel-read-splits branch from 22e44c0 to bcb33ed Compare September 11, 2024 03:43
@JingsongLi
Copy link

+1

@JingsongLi JingsongLi merged commit 5f18615 into apache:main Sep 11, 2024
1 check failed
@yuzelin yuzelin deleted the parallel-read-splits branch October 10, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants