-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TableRead supports reading multiple splits parallely #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzelin
force-pushed
the
parallel-read-splits
branch
2 times, most recently
from
September 4, 2024 09:11
f186f88
to
44d4985
Compare
JingsongLi
reviewed
Sep 5, 2024
batch_iterator = self._batch_generator() | ||
return RecordBatchReader.from_batches(self._arrow_schema, batch_iterator) | ||
|
||
def create_reader_from_split(self, split: Split): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this method
JingsongLi
reviewed
Sep 5, 2024
paimon_python_api/table_read.py
Outdated
def create_reader_from_split(self, split: Split) -> RecordBatchReader: | ||
"""Reader that only read one split.""" | ||
|
||
def create_reader_from_plan(self, plan: Plan) -> RecordBatchReader: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this method
yuzelin
changed the title
Add TableRead#create_parallel_reader for reading multiple splits parallely
TableRead supports reading multiple splits parallely
Sep 5, 2024
yuzelin
force-pushed
the
parallel-read-splits
branch
from
September 11, 2024 03:43
22e44c0
to
bcb33ed
Compare
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
TableRead#create_reader read splits parallely by default. If user hasn't set thread number, then it fallback to sequentially read.
Tests
API and Format
Documentation