This improves the way Nutch is erroring out, at least for local mode. #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewismc
reviewed
Oct 20, 2024
| curTime = conf.getLong("injector.current.time", | ||
| System.currentTimeMillis()); | ||
| url404Purging = conf.getBoolean(CrawlDb.CRAWLDB_PURGE_404, false); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Exception is very vague. I would suggest we figure out what types of Exception's are thrown then catch and raise them instead. What do you think @HiranChaudhuri ?
There was a problem hiding this comment.
I would not know how to define what types of Exceptions can be thrown. Be aware that logging needs to happen for checked and unchecked exceptions. And be aware you cannot see all the code: It loads plugins. Your catch method needs to be compatible to all existing and future code.
So I do not know how to make the catch block any more concise than it is right now. If you can, please show me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nutch will print more information to the logfile - which in local mode ends up on the terminal.
Not sure what will happen in distributed mode though.