Skip to content

Conversation

@ebarboni
Copy link
Contributor

No description provided.

@ebarboni ebarboni requested a review from mbien October 28, 2025 15:29
@ebarboni ebarboni added CI continuous integration changes profiler labels Oct 28, 2025
@mbien
Copy link
Member

mbien commented Oct 29, 2025

the locked SDK version was introduced in #3665, sounds like it was a workaround to fix the build. Should be ok to switch back to latest I suppose. Will the binaries still work on win 10?

@mbien mbien modified the milestones: NB28, NB29 Oct 29, 2025
@ebarboni
Copy link
Contributor Author

the locked SDK version was introduced in #3665, sounds like it was a workaround to fix the build. Should be ok to switch back to latest I suppose. Will the binaries still work on win 10?

It should be backward compatible, and if we use non compatible code it shoud fail maybe.

Cannot test that, this version is not allowed in my uni.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for investigating and fixing the build

@ebarboni ebarboni merged commit bdd4b93 into dependabot/github_actions/actions/download-artifact-6 Oct 30, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration changes profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants