Find Usage performance: moved classpath merging out of the inner loop #8957
+52
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
instead of merging entries into the ClassPath one by one, we collect them first to build the ClassPath as final step. this method is mostly used by the find usage action
mbien
changed the title
mbien
force-pushed
the
find-usages-cp-merge-performance
branch
from
1a7bb26 to
b839953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of merging entries into the
ClassPathone by one, we collect them first to build theClassPathas final step.this method is mostly used by the find usage action
getClasspathInfoFor()execution time in ms with all NB modules open during find-usage action on a public method:(the middle section of the loop had the wrong indentation level, recommending to ignore whitespace during diff)