Skip to content

Conversation

@ebarboni
Copy link
Contributor

@ebarboni ebarboni commented Oct 16, 2025

Snapshot of APIs as of NetBeans 28.

Created using -

# checkout branch (or release tag)
git checkout release280
ant clean
ant build
ant gen-sigtests-release
git add -A
git stash
git checkout master
git checkout -b apis-nb29
git stash pop
git add -A
git commit -m "Snapshot of APIs as of NetBeans 28"
# remove getPeer() calls
find . -name "*.sig" -exec sed -i '/java.awt.peer.ComponentPeer/{N;d;}' {} \;
# check git diff
git add -A
git commit --amend

Filtered diff created using -

curl -L https://github.com/apache/netbeans/pull/8926.diff | filterdiff -#2- > filtered-apis-nb280.txt

filtered-apis-nb280.txt

@ebarboni ebarboni added the Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes. label Oct 16, 2025
@ebarboni ebarboni added this to the NB28 milestone Oct 16, 2025
@apache apache locked and limited conversation to collaborators Oct 17, 2025
@apache apache unlocked this conversation Oct 17, 2025
@matthiasblaesing
Copy link
Contributor

Looked through these and to me the changes looked sane.

@mbien
Copy link
Member

mbien commented Oct 22, 2025

looked through the filtered list and it looked ok to me (but this is essentially impossible to review). Most of it are jdk sigs.

We should merge this soon, right?

@mbien
Copy link
Member

mbien commented Oct 25, 2025

going to merge this in about 10h unless told otherwise till then.

@neilcsmith-net neilcsmith-net added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Oct 25, 2025
@neilcsmith-net
Copy link
Member

API snapshots merge after release. It should be regenerated and updated in the PR after release just in case anything changes. Ideally these are opened early in the cycle to double check nothing unintended has happened while it can still be fixed.

@mbien
Copy link
Member

mbien commented Oct 25, 2025

ok. The reason would be to avoid merge conflicts from delivery? I waited with other merges to master since I thought it made sense to merge them after the global spec bump. But if thats not the case I will start merging other, smaller PRs later today.

@neilcsmith-net
Copy link
Member

The reason is they can change by release. This always used to be just a post-release task until we had an issue that might have been resolvable by doing this in draft form earlier.

Had a very quick look at the filtered diff file, but travelling and using my phone so not exactly usefully enough to stake a review on it! 😄 It might be good to find a way to also filter out changes caused by language level increments in that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Don't merge this PR, it is not ready or just demonstration purposes. Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants