-
Couldn't load subscription status.
- Fork 911
Snapshot of APIs as of 28 #8926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Looked through these and to me the changes looked sane. |
|
looked through the filtered list and it looked ok to me (but this is essentially impossible to review). Most of it are jdk sigs. We should merge this soon, right? |
|
going to merge this in about 10h unless told otherwise till then. |
|
API snapshots merge after release. It should be regenerated and updated in the PR after release just in case anything changes. Ideally these are opened early in the cycle to double check nothing unintended has happened while it can still be fixed. |
|
ok. The reason would be to avoid merge conflicts from delivery? I waited with other merges to master since I thought it made sense to merge them after the global spec bump. But if thats not the case I will start merging other, smaller PRs later today. |
|
The reason is they can change by release. This always used to be just a post-release task until we had an issue that might have been resolvable by doing this in draft form earlier. Had a very quick look at the filtered diff file, but travelling and using my phone so not exactly usefully enough to stake a review on it! 😄 It might be good to find a way to also filter out changes caused by language level increments in that file. |
Snapshot of APIs as of NetBeans 28.
Created using -
Filtered diff created using -
filtered-apis-nb280.txt