-
Couldn't load subscription status.
- Fork 912
[NETBEANS-5024] add support for generics angle brackets #8834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
you formatted the whole file unfortunately :( We typically avoid doing unnecessary whitespace changes and limit them to the rewritten sections. (A few fixes here and there are ok, e.g same method) |
|
Sorry for that. I started with some debuging and some experiments and unfortunately I had a different formatting options. So after some time I realized that I had something that works but the source file was full of debug outputs and temporary code with a wrong formatting. So I tried to reformat the whole code as an attempt to fix it... |
|
For anyone wanting to have a look, this branch has an additional commit revering the unnessary whitespace changes: https://github.com/matthiasblaesing/netbeans/tree/pr-8834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jherkel could you please check my referenced branch:
- 4f9a93e and c0bcae2 cleanup the unnessary changes
- b92297c adjust two names so that they reflect the intented usage
- c77d09e use correct return (
nullfor no match) - a1e5f0e adds minimal test cleanup
From my POV these could be squashed into the initial commit to reduce the differences and make it clearer to read.
A quick test was successful and this looks good to me. The added tests looks sane, but a negative test with bitshift/comparison operators would be good.
|
Outside this PR was the comment:
Ok, I understand. That needs a comment though if kept. The correct solution would be to return Cite from
|
Original issue #5024
This fixes a generics angle bracket highlighting. It works for a multichar token like GTGT and GTGTGT. It ignores logic and arithmetic operators. As we need to distinguish between these two cases, java parser is used for this check.
I added also unit tests.
There is a similar commit #8500 but I don't think it can work in this way and there is no other activity since May 2025.