Unused in package hint: optimize used-in-package scenario #8524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By assuming that most code is used, we can focus on the scenario where an Element is used in a package local file and cache it.
This avoids having to repeatedly scan the package for usage.
The not-used case is not cached, this allows a much simpler impl.
UnusedDetector
SemanticHighlighterBase
and related files, some logging improvementsbefore:
after:
test case is
RepositoryUpdater.java
; each log event is a code modification. Performance improves once caches fill.