-
Notifications
You must be signed in to change notification settings - Fork 914
fixes omission in refactoring for record, inner to outer and pullup. #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This is the seventh PR opened that claims to solve this issue! Please make sure PRs are ready for review when opened, or mark them as draft so people know how to treat them. Some of us are tracking all notifications in the repo. And please, in most cases force push your original branch to keep the original PR open so the connection to any discussions and review is not lost. Is this PR reviewable at this point? |
Sorry for the inconvenience, if I messed up. According to lahodaj and mbien my earlier attempts were way too big, to which I agree. Rolling back my rejected changes was undoable, so I simply started again and picked the usable parts
Yes, its is reviewable and way smaller. It passes all tests, including some I had to add after I found some additional issues, where previous attempts messed CasualDiff and its friends put up a fair fight to understand them. It was a steep learning curve for me. Thank you for your patience. |
|
solves #7044 |
|
Nice. @homberghp thanks for your efforts and assertiveness!! |
b63bad3 to
7ad38cd
Compare
* added tests to show the issues. * added junit test helper to make test output better understandable: AssertLinesEqualHelpers.java * added RECORD case label where appropriate, for instance where the record template should be used. * added factory for Record classTree in TreeFactory and TreeMaker * added/improved methods in CasualDiff and VeryPretty to pick op parameters from record in constructor, so that var args are preserved. Author: Pieter van den Hombergh (homberghp) <[email protected]> Date: Mon Jun 23 11:59:04 2025 +0200
This PR closes #7044
The issue describes that record info was lost when doing and inner to outer or pull up refactoring.
In this pull request
var args are preserved.
And also: minimal drive-by changes.