Skip to content

Conversation

@homberghp
Copy link
Contributor

@homberghp homberghp commented Apr 24, 2025

This PR closes #7044

The issue describes that record info was lost when doing and inner to outer or pull up refactoring.

In this pull request

  • tests to show the issue.
  • junit test helper to make test output better understandable: AssertLinesEqualHelpers.java
  • added factory for Record classTree in TreeFactory and TreeMaker
  • improved methods in CasualDiff and VeryPretty to pick op parameters from record in constructor, so that
    var args are preserved.

And also: minimal drive-by changes.

@homberghp homberghp changed the title Issue7044d Solves issue #7044 refactoring for record, inner to outer and pullup. Apr 24, 2025
@neilcsmith-net
Copy link
Member

This is the seventh PR opened that claims to solve this issue! Please make sure PRs are ready for review when opened, or mark them as draft so people know how to treat them. Some of us are tracking all notifications in the repo. And please, in most cases force push your original branch to keep the original PR open so the connection to any discussions and review is not lost.

Is this PR reviewable at this point?

@homberghp
Copy link
Contributor Author

This is the seventh PR opened that claims to solve this issue! Please make sure PRs are ready for review when opened, or mark them as draft so people know how to treat them. Some of us are tracking all notifications in the repo. And please, in most cases force push your original branch to keep the original PR open so the connection to any discussions and review is not lost.

Sorry for the inconvenience, if I messed up. According to lahodaj and mbien my earlier attempts were way too big, to which I agree. Rolling back my rejected changes was undoable, so I simply started again and picked the usable parts
of the earlier attempt.

Is this PR reviewable at this point?

Yes, its is reviewable and way smaller.

It passes all tests, including some I had to add after I found some additional issues, where previous attempts messed
up unrelated tests, in particular Rename.
In this version I stick to the bare minimum to in the code, although some more work has been done on the testing front.

CasualDiff and its friends put up a fair fight to understand them.

It was a steep learning curve for me. Thank you for your patience.

@homberghp homberghp changed the title Solves issue #7044 refactoring for record, inner to outer and pullup. closes 7044 refactoring for record, inner to outer and pullup. Jun 13, 2025
@homberghp
Copy link
Contributor Author

solves #7044

@homberghp homberghp changed the title closes 7044 refactoring for record, inner to outer and pullup. fixes omission in refactoring for record, inner to outer and pullup. Jun 13, 2025
@BradWalker
Copy link
Member

Nice. @homberghp thanks for your efforts and assertiveness!!

@homberghp homberghp force-pushed the issue7044d branch 3 times, most recently from b63bad3 to 7ad38cd Compare June 22, 2025 17:58
@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Jun 22, 2025
* added tests to show the issues.
* added junit test helper to make test output better understandable: AssertLinesEqualHelpers.java
* added RECORD case label where appropriate, for instance where the record template should be used.
* added factory for Record classTree in TreeFactory and TreeMaker
* added/improved methods in CasualDiff and VeryPretty to pick op parameters from record in constructor, so that
 var args are preserved.

Author:    Pieter van den Hombergh (homberghp) <[email protected]>
Date:      Mon Jun 23 11:59:04 2025 +0200
@homberghp
Copy link
Contributor Author

@mbien @lahodaj Ready for review.
I merged the PRs into one and applied all corrections you both suggested in your reviews of my earlier PRs.

Thank you both for your patience and teaching.
Have a nice day

@neilcsmith-net neilcsmith-net requested review from lahodaj and mbien July 8, 2025 20:56
@neilcsmith-net neilcsmith-net added this to the NB27 milestone Jul 8, 2025
@ebarboni ebarboni modified the milestones: NB27, NB28 Jul 23, 2025
@ebarboni ebarboni modified the milestones: NB28, NB29 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor "Move Inner to Outer level and PullUp" on record drops the record details

5 participants