Fix #8087-Unable to add new web service client #8228

pepness · 2025-02-10T21:28:55Z

Fix issue 8087
NetBeans Notes:

Add support for Jakarta EE 9/10 plugins for metro, jax-ws, and maven-war-plugin
Add support for jakarta namespaces for Jakarta EE 9 and later
Change jax-ws group id to com.sun.xml.ws
Add instance variables to JaxWsClientCreator that will help with the new logic to support jakarta namespaces and reduce method calls
Refactor code and add missing add support for creating web service clients for EJB, CAR and Java SE maven
projects
Simplify logic that compute whether a project is Web, Car, Jar, EJB
Add missing EJB version support
Add missing Servlet version support
Add missing AppClient descriptor for Jakarta EE 11
Add missing AppClient resolvers Java EE 7 to Jakarta EE 11
Add new method getProfile()
Change logic in getJ2eeProfile() and use the new method getProfile()
Remove version model when calling addJaxWSPlugin(), the default version will vary for the computed Profile, Java EE 8 will use model 2.2, Jakarta EE 9/10/11 will use 3.0
Generate new code for equals() and hashCode() methods
Use Pattern Matching for instanceof
Use Switch Expressions
Use constants when possible
Use diamond inference
Use try-with-resources
Increase array size

NetBeans Testing:

Verify successful execution of libraries and licenses Ant test
Verify successful execution of Verify Sigtests
Verify successful execution of unit tests for modules maven.jaxws
Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
Successfully register GlassFish 5/6/7
- Create a Jakarta EE 8/9/10 maven web app and create a new Web Service from WSDL and Web Service Client
  - Verify that it creates a new Web Service
  - Verify that the generated sources are using the correct version plugins
  - Verify that the generated sources are using the correct namespace

Jakarta EE 8

Jakarta EE 9

Jakarta EE 10

matthiasblaesing

Thank you! In general looks sane to me. I left inline comments.

matthiasblaesing · 2025-02-16T18:16:57Z

enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java

+
+    public static final String MAVEN_PLUGINS_GROUP_ID = "org.apache.maven.plugins"; //NOI18N
+    public static final String WAR_PLUGIN_ARTIFACT_ID = "maven-war-plugin"; //NOI18N
+    public static final String WAR_PLUGIN_VERSION = "2.3.4"; //NOI18N


I would bump to 3.4.0 if there is not a very good reason to stay on the old version. I remember that I bumped several projects to a 3.X version as 2.X failed when used with JDK 21+

matthiasblaesing · 2025-02-16T18:20:55Z

enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java

 */
 public final class MavenModelUtils {

+    private static Profile profile;


This will become a problem. If you have one maven project with JakartaEE and one with JavaEE open, both will use the same profile. You will need to pass the "isJakarta" property (or the profile) from the external entry points, to decide per call.

A passing question: is it save to assume this is only called for JavaEE/JakarataEE projects? If it is called for JavaSE projects, there will be no profile.

maven-war-plugin -Add support for jakarta namespaces for Jakarta EE 9 and later -Change jax-ws group id to 'com.sun.xml.ws' -Add instance variables to 'JaxWsClientCreator' that will help with the new logic to support jakarta namespaces and reduce method calls -Use constants when possible -Use diamond inference -Use try-with-resources -Increase array size

Add missing Servlet version support Add missing AppClient descriptor for Jakarta EE 11 Add missing AppClient resolvers Java EE 7 to Jakarta EE 11 Bump default profile return to Jakarta EE 8

@OverRide

Add @OverRide annotation Use diamond operator Use parseBoolean over valueOf Use Multi-catch Bump default deployment descriptor to AppClient 8 Replace usage of deprecated methods from codehaus

Remove subtypes from @ProjectServiceProvider

when computing the profile in all implementations. -Add getSourceLevel method to MavenProjectSupport, useful with JSE maven projects

-Change logic in getJ2eeProfile() and use the new method getProfile() -Generate new code for equals() and hashCode() methods -Use Pattern Matching for instanceof -Use Switch Expressions

-Remove subtypes from @ProjectServiceProvider -Use psf LOGGER -

-Fix wrong if statement -Remove version model when calling addJaxWSPlugin(), the default version will vary for the computed Profile, Java EE 8 will use model 2.2, Jakarta EE 9/10/11 will use 3.0.

projects.

-Add support for Car and Jar projects to isJakartaEENameSpace() -Add method getSourceLevel()

file -Add module maven.jaxws as a friend

-Pattern Matching for instanceof -Switch Expressions

-Add useful variable for debugging -Remove unused imports

types should be in the same if statement.

retrieve the correct Profile.

Use try-with-resources

mbien

left some comments while looking through it - nice cleanups!

(please don't forget to squash btw)

enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ear/EarImpl.java

enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/WSUtils.java

-Remove the redundant Xpp3Dom variable -close all wrapped streams in try-with-resources with 'bw'

matthiasblaesing · 2025-08-31T18:48:13Z

@pepness what is the state of this? I think it would be good to rebase this onto current master, cleanup the history and check if all comments are addressed. The static profile variable is still there and globals like these are really ugly to debug.

pepness added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Feb 10, 2025

pepness added this to the NB26 milestone Feb 10, 2025

pepness self-assigned this Feb 10, 2025

pepness linked an issue Feb 10, 2025 that may be closed by this pull request

Unable to add new web service client #8087

Open

pepness mentioned this pull request Feb 10, 2025

Unable to add new web service client #8087

Open

matthiasblaesing requested changes Feb 16, 2025

View reviewed changes

neilcsmith-net modified the milestones: NB26, NB27 Apr 16, 2025

pepness force-pushed the fix-8087 branch from 0892122 to 0756f30 Compare April 28, 2025 20:44

pepness added 20 commits June 18, 2025 15:28

Add missing EJB version support

e55f8e0

Add missing Servlet version support Add missing AppClient descriptor for Jakarta EE 11 Add missing AppClient resolvers Java EE 7 to Jakarta EE 11 Bump default profile return to Jakarta EE 8

Use try-with-resources

4bd3e3d

Add @OverRide annotation Use diamond operator Use parseBoolean over valueOf Use Multi-catch Bump default deployment descriptor to AppClient 8 Replace usage of deprecated methods from codehaus

Refactor code and add missing support for Client Applications

3f00c2a

Implement missing interface and its methods

8579ae6

Remove subtypes from @ProjectServiceProvider

-Move method getProfileFromPOM to MavenProjectSupport class and use it

fcdf19b

when computing the profile in all implementations. -Add getSourceLevel method to MavenProjectSupport, useful with JSE maven projects

-Add new method getProfile()

91eda82

-Change logic in getJ2eeProfile() and use the new method getProfile() -Generate new code for equals() and hashCode() methods -Use Pattern Matching for instanceof -Use Switch Expressions

-Remove unused imports

c2dc126

-Remove subtypes from @ProjectServiceProvider -Use psf LOGGER -

-Add import for Plugin class

4adb600

-Fix wrong if statement -Remove version model when calling addJaxWSPlugin(), the default version will vary for the computed Profile, Java EE 8 will use model 2.2, Jakarta EE 9/10/11 will use 3.0.

Add support for creating web services for EJB, CAR and Java SE maven

f1f3fb3

projects.

-Simplify logic that compute whether a project is Web, Car, Jar, EJB

3637c07

-Add support for Car and Jar projects to isJakartaEENameSpace() -Add method getSourceLevel()

-Add a new module dependency in order to get the source level of a java

bca5baa

file -Add module maven.jaxws as a friend

Bump javac to version 17 and use:

71e3a2b

-Pattern Matching for instanceof -Switch Expressions

-Add useful comment for debugging

9fedfe7

-Add useful variable for debugging -Remove unused imports

Fix wrong artifact and update GlassFish 7/8 version

6aa3c63

Revert: When creating capabilities for a project the EJB & WAR project

9721d1c

types should be in the same if statement.

Revert: Remove subtypes from @ProjectServiceProvider

e8d98ea

Update maven coordinates inside test

f773777

Fix mismatch when using MavenProjectSupport.getProfileFromPOM() to

3116743

retrieve the correct Profile.

Add Logger and use it

02d35fd

Use try-with-resources

pepness force-pushed the fix-8087 branch from 2031e69 to 02d35fd Compare June 19, 2025 22:31

mbien added the Maven [ci] enable "build tools" tests label Jun 20, 2025

mbien reviewed Jun 20, 2025

View reviewed changes

-equals() and hashCode( should cover the same fields

897da59

-Remove the redundant Xpp3Dom variable -close all wrapped streams in try-with-resources with 'bw'

neilcsmith-net requested a review from matthiasblaesing July 18, 2025 14:23

ebarboni modified the milestones: NB27, NB28 Jul 23, 2025

ebarboni modified the milestones: NB28, NB29 Oct 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #8087-Unable to add new web service client #8228

Fix #8087-Unable to add new web service client #8228

Uh oh!

pepness commented Feb 10, 2025 •

edited

Loading

Uh oh!

matthiasblaesing left a comment

Uh oh!

matthiasblaesing Feb 16, 2025

Uh oh!

matthiasblaesing Feb 16, 2025

Uh oh!

mbien left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthiasblaesing commented Aug 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix #8087-Unable to add new web service client #8228

Are you sure you want to change the base?

Fix #8087-Unable to add new web service client #8228

Uh oh!

Conversation

pepness commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiasblaesing left a comment

Choose a reason for hiding this comment

Uh oh!

matthiasblaesing Feb 16, 2025

Choose a reason for hiding this comment

Uh oh!

matthiasblaesing Feb 16, 2025

Choose a reason for hiding this comment

Uh oh!

mbien left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthiasblaesing commented Aug 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pepness commented Feb 10, 2025 •

edited

Loading

mbien left a comment •

edited

Loading