Skip to content

test(terminal): restore real Host copy undo and interruption coverage - #6736

Closed
me2seeks wants to merge 1 commit into
rust-previewfrom
fix/tui-copy-undo-interrupt
Closed

me2seeks wants to merge 1 commit into
rust-previewfrom
fix/tui-copy-undo-interrupt

Conversation

@me2seeks

Copy link
Copy Markdown
Contributor

Summary

Restore the real-Host terminal keyboard regression removed from the CLI integration target by #6713. This keeps the copy-key production fix in #6731 verifiable against its original end-to-end behavior instead of treating a disappeared test as a successful fix.

The test exercises:

  • back-to-back Select All and Copy without clearing the draft or triggering terminal exit;
  • collapsing the selection, Ctrl+C draft clearing, Undo restoration and clearing again;
  • two real streamed model runs, Escape cancellation, Ctrl+C confirmation, Keep running, dismissing without stopping, and explicit Stop;
  • the exact durable RunIds and only the two intended model requests.

Reuse the existing Host fixture and migrate the restored assertions to the durable RunId execution contract. Keep only the helpers this case uses, and check that its cross-directory source inputs still route to the CLI consumer.

This is verification restoration, not a new copy-key production fix: #6731 already contains that fix. No sleeps, longer timeouts, skips or retry policies were added.

Refs #6713, #6731, #6723.

Verification

  • Focused CI routing and existing required-job checks: passed.
  • Targeted Biome, stable rustfmt and git diff --check: passed.
  • The real restored test and the single-variable pre-fix/fixed comparison are pending. This PR remains Draft until that loop has been executed; mock routing results are not end-to-end evidence.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Maka investigated the missing consumer, restored the relevant real-Host scenario and durable execution assertions, and maintained the CI input-routing check. Material commits carry Generated-by: Maka.

Checklist

  • Tests cover the change and fail without it
  • Format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No — restores regression execution without changing production behavior

Reconnect the CLI integration entry removed during durable execution migration. Keep the real composer copy, clear, undo and exact-Run stop-confirmation chain while omitting unrelated history search and retired suites.

Use durable Run ids and execution states, retain the existing Host fixture, and preserve actionable wait call sites. Cover the keyboard fixture and editor inputs' reverse-dependency route to the required CLI root tests.

Generated-by: Maka
@me2seeks

Copy link
Copy Markdown
Contributor Author

Maka (AI agent): closing at the user’s request. The production copy-key fix is already merged in #6731. This PR only restores a legacy verification entry and is not necessary for the residency fix in #6723. Its migrated fixture currently fails during UI initialization, before the Ctrl+C scenario, so no end-to-end success or production repair is claimed. Further CI work will focus on the actual current native consumers rather than keeping an unvalidated test-restoration PR.

@me2seeks me2seeks closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant