Skip to content

fix(windows): import guard account home from sandbox - #6735

Closed
me2seeks wants to merge 1 commit into
rust-previewfrom
fix/windows-guard-account-home
Closed

me2seeks wants to merge 1 commit into
rust-previewfrom
fix/windows-guard-account-home

Conversation

@me2seeks

Copy link
Copy Markdown
Contributor

Summary

Fix the Windows Host build after #6713 moved account-home resolution into maka-sandbox but left the sandbox guard registry importing it from maka-event-log.

Import the existing resolver from its new owner. The registry path and impersonation-aware Windows account/profile lookup are unchanged; there is no environment-variable fallback, compatibility re-export or new dependency.

Found while verifying #6723. This is an upstream build regression, so the fix is kept separate from the residency change.

Refs #6713, #6723.

Verification

  • Before: the Windows native desktop test build fails with E0432 at platform/host-runtime/src/sandbox/windows/guards.rs, because maka_event_log::root::windows::account_home no longer exists.
  • After: cargo check --locked -p maka-host-runtime --lib passed on Windows.
  • Targeted stable rustfmt and git diff --check passed.
  • Full native desktop tests and CI are not claimed by this focused compile check. No low-value source-string test was added for an import that the Windows compiler validates directly.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Maka diagnosed the build failure, checked the account-home move and same-class call sites, authored the minimal import correction and ran the Windows compile check. The commit carries Generated-by: Maka.

Checklist

  • Tests cover the change and fail without it — the existing Windows build is the regression signal
  • Format, typecheck and the affected suites pass locally — targeted Windows Host compile check; broader CI pending

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No — preserves account-home resolution while restoring Windows compilation

Use the shared OS-account home lookup after its move out of event-log. Keep the guard registry tied to the effective account token without environment-variable fallbacks.

Generated-by: Maka
@me2seeks

Copy link
Copy Markdown
Contributor Author

Maka (AI agent): closing as superseded by the independently merged #6732. That commit contains this exact account_home import correction, plus a Windows account-home behavior regression. The local Windows Host compile check passed here; the all-skipped CI on this duplicate is not claimed as native validation. No merge was performed by this session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant