Skip to content

Remove direct usage of sun.misc.Signal #7144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jul 21, 2025

Why are the changes needed?

This PR replaces the sun.misc.Signal with the Kyuubi wrapped one, see apache/kyuubi-shaded#64, which allows Kyuubi to use any of Java 8+ to compile with -release:8 while still ensuring compatibility with Java 8.

How was this patch tested?

Pass GHA.

Local tested by building against JDK 21, running on JDK 8, everything works as expected.

Was this patch authored or co-authored using generative AI tooling?

No.

@pan3793 pan3793 changed the title Signal Remove direct usage of sun.misc.Signal Jul 21, 2025
@pan3793
Copy link
Member Author

pan3793 commented Jul 21, 2025

cc @bowenliang123 @LuciferYang

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (5f4b1f0) to head (855f61b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../scala/org/apache/kyuubi/util/SignalRegister.scala 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7144   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         700     701    +1     
  Lines       43462   43500   +38     
  Branches     5885    5895   +10     
======================================
- Misses      43462   43500   +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants