[WIP][KYUUBI #3723]Add SQL session state management and save metadata #7143
+143
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new SessionState enum to define possible session states. - Insert or update metadata at different stages of the session lifecycle.
|
Hi @turboFei and other maintainers, I've just submitted this as a Draft PR for some early feedback. Could you please take a look at the general approach and let me know if there are any initial suggestions? Thanks! |
turboFei
reviewed
Jul 20, 2025
| @@ -73,6 +77,39 @@ class KyuubiSessionImpl( | |||
| case (key, value) => sessionConf.set(key, value) | |||
| } | |||
|
|
|||
| val (clusterManager, kubernetesInfo) = engine.engineType match { | |||
There was a problem hiding this comment.
For the clusterManager, I think you can leave it empty and update it after getting the engine info.
But seems it does not matter.
There was a problem hiding this comment.
FYI:
There was a problem hiding this comment.
Got it, thanks for the guidance! I will get this updated.
turboFei
reviewed
Jul 20, 2025
| SessionState.validateTransition(state, newState) | ||
| newState match { | ||
| case SessionState.RUNNING => | ||
| info(s"Session is ready.") |
There was a problem hiding this comment.
this kind of log is meaningless without session identifier
turboFei
reviewed
Jul 20, 2025
| case SessionState.RUNNING => | ||
| info(s"Session is ready.") | ||
| case SessionState.ERROR | SessionState.TIMEOUT | SessionState.CLOSED => | ||
| info(s"Session is terminated.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
#3723
How was this patch tested?
No,it's just a draft.
Was this patch authored or co-authored using generative AI tooling?
No.