Packaging environment using pyproject.toml; change configuration of pre-commit hooks; use __version__ for project build version. #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: In handler.py method traceback and use in exception; Add print statements (as debug hints) in session,py and other modules; Fix in handler.py by removing bucket (which is no key, value pair) from setting into session headers as argument for start_response call); Add __init__py in plugins folder to allow import from makeAccount.py and remove local KibbleDatabase class there; Make in database.py *Wrapper classes private; Add into kibble.yaml configuration key elasticsearch versionHint (by default 8) to allow for more robust and transparent initialization; Refactor in setup.py into methods makeIndices and makeAccount(); Fix check for undefined snap in kibble.v1.js. Improvement: Evaluate result in makeAccount.py; Remove cgi import (not used) and deprecated since py 3.11; Use __debug__ to print out more debugging information; Set cookie httpOnly; Update setup docs (tested with python 3.9.1 and 3.13.0).
…ts to replace interval with calendar_interval in body lists. See https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-datehistogram-aggregation.html#calendar_and_fixed_intervals Fix NPE err.message in handler.py and use traceback_output (needs more filtering to not expose stacktraces pathes)
…rgument is never set
…; add infos about packaging in README.md; Provide a project version reference __version__ in handler, currently set to 1.0.0; Comment debugging statements and add warning for duplicate size in search request. Change in pre-commit-config check hook to pre-stages and update versions of pre-commit-hooks and pre_commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__version__in handler, currently set to 1.0.0