KAFKA-20719: "Streams" group sticky assignor not sticky at startup#22783
Open
gabriellefu wants to merge 1 commit into
Open
KAFKA-20719: "Streams" group sticky assignor not sticky at startup#22783gabriellefu wants to merge 1 commit into
gabriellefu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Broker (
StickyTaskAssignor)Reported task offsets now act as a fallback previous-ownership signal.
Members reporting on-disk state for a task are registered as standby-strength candidates for it:
The assignment phases are unchanged, so precedence is now:
For groups where no member reports offsets for unowned tasks, the assignment is unchanged.
Client (
StreamThread)The task-offset-sum snapshot is now populated before the consumer subscribes.
Previously it was only refreshed inside the poll loop, which races the join:
TaskOffsetslist on cold startSince offset updates do not bump the group epoch, the assignment computed after the initial rebalance delay never saw the offsets that arrived on subsequent heartbeats.
With this change, the join heartbeat reliably carries the state-directory-derived offsets, as intended by
KAFKA-20116. This also benefits the warm-up refinement work, which consumes the same fields.Testing
ColdStartStickinessIntegrationTest.shouldStickToLocalStateOnColdStart(added disabled in#22630)StickyTaskAssignorTestcovering:StickyTaskAssignorTestandStreamThreadTestsuites pass unchanged