KAFKA-20769: ListDeserializer can silently deserialize a corrupted entry when the input is truncated mid-entry#22755
Open
SEPURI-SAI-KRISHNA wants to merge 1 commit into
Conversation
…try when the input is truncated mid-entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListDeserializer.deserialize only treated a -1 return from
DataInputStream.read(byte[]) as a truncated stream, but read may return a
partial count without reaching EOF. The entrySize bounds check compares
against data.length (the whole buffer), not the bytes remaining, so a
corrupted payload can declare an entry size that passes the check yet
exceeds the remaining bytes. When that happens the entry buffer is left
zero-padded and handed to the inner deserializer with no error, silently
producing a corrupted value instead of the intended
SerializationException("End of the stream was reached prematurely").
Switch to DataInputStream.readFully, which throws EOFException when the
buffer cannot be filled, and map it to the existing SerializationException.
Behavior is unchanged for well-formed input.
Testing: added ListDeserializerTest.shouldThrowOnEntryTruncatedMidStream,
which encodes a VARIABLE_SIZE list declaring a 10-byte entry but supplying
only 5 payload bytes. The test fails without the fix (no exception thrown,
corrupted entry returned) and passes with it. Full ListDeserializerTest
suite, checkstyle, and spotless pass locally.
Co-Authored-By: Claude Fable 5