Skip to content

MINOR: Prevent re-join flakiness in test_fencing_static_consumer by ensuring conflicting static consumers terminate #20772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2025
+26 −3
Merged

MINOR: Prevent re-join flakiness in test_fencing_static_consumer by ensuring conflicting static consumers terminate #20772

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ead1999
MINOR: ensure static consumer fencing test waits for UnreleasedInstan…
apalan60 Oct 25, 2025
712ac9a
Address comments
apalan60 Oct 25, 2025
626f55d
fix:ensure conflict consumers reach shutdown in fencing test
apalan60 Oct 30, 2025
3090f4f
chore: Add clarifying comment for conflict consumer termination in fe…
apalan60 Oct 30, 2025
09aef08
Merge remote-tracking branch 'upstream/trunk' into MINOR-1022
apalan60 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion tests/kafkatest/tests/client/consumer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from ducktape.mark.resource import cluster

from kafkatest.tests.verifiable_consumer_test import VerifiableConsumerTest
from kafkatest.services.verifiable_consumer import VerifiableConsumer
from kafkatest.services.kafka import TopicPartition, quorum, consumer_group

import signal
Expand Down Expand Up @@ -74,6 +75,20 @@ def setup_consumer(self, topic, **kwargs):
self.mark_for_collect(consumer, 'verifiable_consumer_stdout')
return consumer

def _node_failed_with_unreleased_instance_id(self, node):
cmd = "grep -q 'UnreleasedInstanceIdException' %s" % VerifiableConsumer.LOG_FILE
Copy link
Member

@chia7712 chia7712 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the error is subject to change, would it be more reliable to check the process ID (PID) directly?

Copy link
Contributor Author

@apalan60 apalan60 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712

Thanks for the suggestion!
Given backward compatibility, checking the PID makes more sense.
I’ve made the corresponding adjustment.

return node.account.ssh(cmd, allow_fail=True) == 0

def await_conflict_consumers_fenced(self, conflict_consumer):
wait_until(lambda: len(conflict_consumer.dead_nodes()) == len(conflict_consumer.nodes),
timeout_sec=60,
err_msg="Timed out waiting for conflict consumers to terminate after fencing")

for node in conflict_consumer.nodes:
wait_until(lambda: self._node_failed_with_unreleased_instance_id(node),
timeout_sec=30,
err_msg="Conflict consumer %s did not fail with UnreleasedInstanceIdException" % node.account.hostname)

@cluster(num_nodes=7)
@matrix(
metadata_quorum=[quorum.isolated_kraft],
Expand Down Expand Up @@ -326,7 +341,10 @@ def test_fencing_static_consumer(self, num_conflict_consumers, fencing_stage, me
assert num_rebalances == consumer.num_rebalances(), "Static consumers attempt to join with instance id in use should not cause a rebalance"
assert len(consumer.joined_nodes()) == len(consumer.nodes)
assert len(conflict_consumer.joined_nodes()) == 0


# ensure the conflict consumers terminate
self.await_conflict_consumers_fenced(conflict_consumer)

# Stop existing nodes, so conflicting ones should be able to join.
consumer.stop_all()
wait_until(lambda: len(consumer.dead_nodes()) == len(consumer.nodes),
Expand Down