KAFKA-19831: Improved error handling in DefaultStateUpdater. #20767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nikita-Shupletsov
commented
Oct 24, 2025
Nikita-Shupletsov
commented
- Improved error handling in DefaultStateUpdater to take potential failures in Task#maybeCheckpoint into account.
- Improved TaskManager#shutdownStateUpdater to not hang indefinitely if the State Updater thread is dead.
| return new TaskAndAction(null, taskId, Action.REMOVE, future); | ||
| } | ||
|
|
||
| public static TaskAndAction createRemoveTask(final TaskId taskId) { |
There was a problem hiding this comment.
the non future remove task isn't used anywhere anymore, so I deleted the code that handled it.
also it made the proposed solution a bit tidier
| final Task task; | ||
| if (updatingTasks.containsKey(taskId)) { | ||
| task = updatingTasks.get(taskId); | ||
| private void pauseTask(final Task task) { |
There was a problem hiding this comment.
here it s basically the old pauseTask method wrapped in a try-catch. idk why git decided to show such a strange diff.
the removeTask method was simply deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.