KAFKA-18597 Fix max-buffer-utilization-percent is always 0 #18627
+153
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
@LoganZhuZzz This is a bug fix, so could you please add unit test? |
I’ll add the unit test later. |
chia7712
changed the title
3 tasks
|
@LoganZhuZzz additionally, please take a look at @ijuma's comment (#17390 (comment)) |
LoganZhuZzz
force-pushed
the
KAFKA-18597
branch
from
13ad210 to
a399709
Compare
LoganZhuZzz
force-pushed
the
KAFKA-18597
branch
from
a399709 to
66a8451
Compare
LoganZhuZzz
force-pushed
the
KAFKA-18597
branch
from
66a8451 to
3b3700d
Compare
@chia7712 PTAL |
chia7712
reviewed
Jan 23, 2025
|
|
||
| /* a metric to track the maximum utilization of any thread's buffer in the last cleaning */ | ||
| metricsGroup.newGauge(MaxBufferUtilizationPercentMetricName, | ||
| () => maxOverCleanerThreads(_.lastStats.bufferUtilization) * 100) | ||
| () => (maxOverCleanerThreads(_.lastStats.bufferUtilization) * 100).toInt) |
There was a problem hiding this comment.
Could you please add unit test for other impacted metrics?
| } | ||
|
|
||
| @Test | ||
| def testMaxBufferUtilizationPercentMetric(): Unit = { |
There was a problem hiding this comment.
It seems this new unit test is similar to testMaxOverCleanerThreads, right? If so, could you please remove testMaxOverCleanerThreads?
…anerTest - Added testMaxBufferUtilizationPercentMetric to validate maximum buffer utilization metric. - Added testMaxCleanTimeMetric to verify the maximum clean time metric. - Added testMaxCompactionDelayMetrics to ensure correctness of maximum compaction delay metric.
chia7712
approved these changes
Jan 24, 2025
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
) Reviewers: Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
) Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-18597
Committer Checklist (excluded from commit message)