Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17402: DefaultStateUpdated should transit task atomically #18607

Merged
merged 1 commit into from
Jan 21, 2025
Merged

KAFKA-17402: DefaultStateUpdated should transit task atomically #18607

merged 1 commit into from
Jan 21, 2025

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Jan 18, 2025

No description provided.

@mjsax mjsax added the streams label Jan 18, 2025
@github-actions github-actions bot added the small Small PRs label Jan 18, 2025
@mjsax mjsax changed the title KAFKA-17402: DefaultStateUpdated should transite task atomically KAFKA-17402: DefaultStateUpdated should transit task atomically Jan 18, 2025
cadonna
cadonna approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjsax !

This makes sense.

LGTM!

lucasbru
lucasbru approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax
Copy link
Member Author

mjsax commented Jan 21, 2025

Java 17 passed.

Java 23:

Found 3 test failures:
FAILED ❌ ClientIdQuotaTest > testThrottledProducerConsumer(String, String).quorum=kraft.groupProtocol=classic
FAILED ❌ ClientIdQuotaTest > testQuotaOverrideDelete(String, String).quorum=kraft.groupProtocol=classic
FAILED ❌ ClientIdQuotaTest > testQuotaOverrideDelete(String, String).quorum=kraft.groupProtocol=consumer
Found 2 flaky test failures:
FLAKY ⚠️  KafkaAdminClientTest > testAdminClientApisAuthenticationFailure()
FLAKY ⚠️  SslTransportLayerTest > "testSelectorPollReadSize(Args).args=tlsProtocol=TLSv1.2, useInlinePem=false"

Fix for ClientIdQuotaTest was merge yesterday. Let me rebase...

@mjsax mjsax force-pushed the kafka-17402-default-state-updater branch from 1432f09 to 3c9b18c Compare January 21, 2025 16:42
@mjsax
Copy link
Member Author

mjsax commented Jan 21, 2025

Java 23 passed.

Java 17:

Found 1 test failures:
FAILED ❌ KafkaAdminClientTest > testAdminClientApisAuthenticationFailure()
Found 3 flaky test failures:
FLAKY ⚠️  AbstractCoordinatorTest > testWakeupAfterSyncGroupReceivedExternalCompletion()
FLAKY ⚠️  ClientIdQuotaTest > testThrottledProducerConsumer(String, String).quorum=kraft.groupProtocol=classic
FLAKY ⚠️  MetadataVersionIntegrationTest > testBasicMetadataVersionUpgrade [4] Type=Raft-Isolated, MetadataVersion=3.3-IV3,BrokerSecurityProtocol=PLAINTEXT,BrokerListenerName=ListenerName(EXTERNAL),ControllerSecurityProtocol=PLAINTEXT,ControllerListenerName=ListenerName(CONTROLLER)

Not sure about the failed "Gradle Builds Scan" jobs... \cc @mumrah

@mjsax mjsax merged commit f2f9e84 into apache:trunk Jan 21, 2025
6 of 9 checks passed
@mjsax mjsax deleted the kafka-17402-default-state-updater branch January 21, 2025 20:33
mjsax added a commit that referenced this pull request Jan 21, 2025
@mjsax
KAFKA-17402: DefaultStateUpdated should transite task atomically (#18607
7f9cf89 
)

Reviewers: Bruno Cadonna <[email protected]>, Lucas Brutschy <[email protected]>
mjsax added a commit that referenced this pull request Jan 21, 2025
@mjsax
KAFKA-17402: DefaultStateUpdated should transite task atomically (#18607
9f64ef2 
)

Reviewers: Bruno Cadonna <[email protected]>, Lucas Brutschy <[email protected]>
mjsax added a commit that referenced this pull request Jan 21, 2025
@mjsax
KAFKA-17402: DefaultStateUpdated should transite task atomically (#18607
8609ce9 
)

Reviewers: Bruno Cadonna <[email protected]>, Lucas Brutschy <[email protected]>
@mjsax
Copy link
Member Author

mjsax commented Jan 21, 2025

Merged to trunk and cherry-picked to 4.0, 3.9, and 3.8 branches.

pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
@mjsax @pranavt84
KAFKA-17402: DefaultStateUpdated should transite task atomically (apa…
f0ad347 
…che#18607)

Reviewers: Bruno Cadonna <[email protected]>, Lucas Brutschy <[email protected]>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
@mjsax
KAFKA-17402: DefaultStateUpdated should transite task atomically (apa…
3292e35 
…che#18607)

Reviewers: Bruno Cadonna <[email protected]>, Lucas Brutschy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasbru lucasbru lucasbru approved these changes

@cadonna cadonna cadonna approved these changes

Assignees
No one assigned
Labels
small Small PRs streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjsax @cadonna @lucasbru