KAFKA-18559: Cleanup FinalizedFeatures #18593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Jan 18, 2025
There was a problem hiding this comment.
@frankvicky thanks for this patch. please take a look at one small comment.
| this.metadataVersion = metadataVersion; | ||
| this.finalizedFeatures = new HashMap<>(finalizedFeatures); | ||
| this.finalizedFeaturesEpoch = finalizedFeaturesEpoch; | ||
| // In KRaft mode, we always include the metadata version in the features map. |
There was a problem hiding this comment.
Could you please keep the comment "In KRaft mode, we always include the metadata version in the features map"?
There was a problem hiding this comment.
done.
To avoid confusion, I delete the in kraft.
frankvicky
force-pushed
the
KAFKA-18559
branch
from
826cc54 to
0f7db63
Compare
chia7712
reviewed
Jan 19, 2025
| ) { | ||
| Objects.requireNonNull(metadataVersion); | ||
| this.metadataVersion = metadataVersion; |
There was a problem hiding this comment.
Could you please merge them?
this.metadataVersion = Objects.requireNonNull(metadataVersion);There was a problem hiding this comment.
Sure!
I have just updated the patch
JIRA: KAFKA-18559 Cleanup the zk logic and test in `FinalizedFeatures`
frankvicky
force-pushed
the
KAFKA-18559
branch
from
0f7db63 to
7dec89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-18559
Cleanup the zk logic and test in
FinalizedFeaturesCommitter Checklist (excluded from commit message)