JAMES-4072 Enable timeout option in RedisClientFactory #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantranhong1999
approved these changes
Apr 28, 2025
chibenwa
approved these changes
Apr 28, 2025
Arsnael
approved these changes
Apr 28, 2025
| @@ -109,7 +109,7 @@ private String createRedisSentinelURI() { | |||
| sb.append("redis-sentinel://123@"); | |||
| sb.append(this.stream().map(container -> container.getHost() + ":" + container.getMappedPort(SENTINEL_PORT)) | |||
| .collect(Collectors.joining(","))); | |||
| sb.append("?sentinelMasterId=mymaster"); | |||
| sb.append("?sentinelMasterId=mymaster&timeout=3s"); | |||
There was a problem hiding this comment.
This requires the extra configuration change (not everyone is aware of it and applies it everywhere)
I would be defensive in keeping the Reactor timeout as the safeguard.
WDYT?
There was a problem hiding this comment.
I'm no problem with both way
feel free to revert it
There was a problem hiding this comment.
Change or not change? Status on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the
RedisHealthcheck, we are using Reactor's timeout handling, not the timeout provided by Redis Lettuce.With this configuration, the timeout will be correctly handled by the Lettuce library
Reference: redis/lettuce#2614