bugfix: fix IDENTIFIED_CHANNELS leak causing TC FullGC and OOM - #8224
Open
saul-c wants to merge 1 commit into
Open
bugfix: fix IDENTIFIED_CHANNELS leak causing TC FullGC and OOM#8224saul-c wants to merge 1 commit into
saul-c wants to merge 1 commit into
Conversation
When TM/RM clients disconnect (e.g. K8s pod rolling update, HPA scaling), RpcContext.release() only nulled the clientIDHolderMap field instead of removing the dead channel from ChannelManager.IDENTIFIED_CHANNELS. Dead Netty channels (with RpcContext/pipeline/ByteBuf) accumulated forever until the TC ran into continuous FullGC and OOM. - RpcContext.release(): remove the channel from IDENTIFIED_CHANNELS - ChannelManager.releaseRpcContext(): remove the channel defensively - AbstractNettyRemotingServer.handleDisconnect: route through the unified releaseRpcContext entry (used by both READER_IDLE and channelInactive) - NettyClientChannelManager.releaseChannel(): release rpc context too - add ChannelManagerOOMTest reproducing repeated reconnect/disconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When TM/RM clients disconnect (e.g. K8s pod rolling update, HPA scaling), RpcContext.release() only nulled the clientIDHolderMap field instead of removing the dead channel from ChannelManager.IDENTIFIED_CHANNELS. Dead Netty channels (with RpcContext/pipeline/ByteBuf) accumulated forever until the TC ran into continuous FullGC and OOM.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews