test: add UT for dm module #7709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@YvCeung PTAL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7709 +/- ##
============================================
+ Coverage 61.41% 61.70% +0.28%
- Complexity 682 684 +2
============================================
Files 1324 1324
Lines 50047 50046 -1
Branches 5910 5910
============================================
+ Hits 30738 30879 +141
+ Misses 16531 16377 -154
- Partials 2778 2790 +12
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Please turn off pr first and then turn it on again to ensure the successful execution of ci |
Contributor
|
@maple525866 Could you add some unit tests? Thanks |
Contributor
Author
OK, please wait. |
added 2 commits
October 18, 2025 12:37
maple525866
changed the title
YvCeung
changed the title
Contributor
|
LGTM |
YvCeung
approved these changes
Oct 18, 2025
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Since the author of PR No. 7643 did not respond for a long time, we merged his code first. This PR is used to ensure the code format is consistent with the registered PR.
also，I add UT for dm module to increase test coverage
Ⅱ. Does this pull request fix one issue?
fixes #7642
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
mvn clean test
Ⅴ. Special notes for reviews